[Core] Allow module entrypoint to be written in typescript #8873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an unnecessary ".js" added to the name resolution in webpack.config.js which forces the entrypoint of modules referred to by the config to be javascript. This removes it so that .ts/.tsx files can serve as the entrypoint to a module.
|
@laemtl you're probably the only one who's worked with webpack.config.js.. can you review? It's a tiny change. |
|
Yeah! Looks good to me — I guess my only question is that the previous code seemed to restrict it to |
|
I don't see why we would want to restrict the extension at all, if it's something that our webpack configuration supports. |
HenriRabalais
approved these changes
Oct 23, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an unnecessary ".js" added to the name resolution in webpack.config.js which forces the entrypoint of modules referred to by the config to be javascript. This removes it so that .ts/.tsx files can serve as the entrypoint to a module.